From 08495b543def395ebe57e88d826c737e0ed493e6 Mon Sep 17 00:00:00 2001 From: Jan Umbach Date: Tue, 28 May 2024 18:59:33 +0200 Subject: [PATCH] test --- assets/global.js | 4 ++-- snippets/product-media-gallery.liquid | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/assets/global.js b/assets/global.js index 018a04d..1c1b60c 100644 --- a/assets/global.js +++ b/assets/global.js @@ -1139,8 +1139,8 @@ class VariantSelects extends HTMLElement { console.log("galleryImage.getAttribute('thumbnail-alt')", galleryImage.getAttribute('thumbnail-alt')); if (galleryImage.getAttribute('thumbnail-alt') === this.currentVariant.featured_image.alt) { - // check if galleryImage is a video nested - if (!galleryImage.querySelector('video')) { + // check if galleryImage has data-is-video-type attribute + if (galleryImage.dataset.isVideoType !== 'true') { continue; } diff --git a/snippets/product-media-gallery.liquid b/snippets/product-media-gallery.liquid index b5b053b..8d38a87 100644 --- a/snippets/product-media-gallery.liquid +++ b/snippets/product-media-gallery.liquid @@ -238,7 +238,7 @@ class="thumbnail-list__item slider__slide{% if section.settings.hide_variants and variant_images contains media.src %} thumbnail-list_item--variant{% endif %}" data-target="{{ section.id }}-{{ media.id }}" {% if media.media_type == 'video' or media.media_type == 'external_video' %} - data-isVideoType + data-is-video-type="true" {% endif %} data-media-position="{{ media_index }}">